opendev/gerrit
Code Issues Proposed changes

Extract an abstract base class for NotesMigration

Browse Source 
We want to be able to provide a different implementation for testing
that does not require restarting the server in order to pick up
changes. This will allow us to test rebuilding on a running server,
which fits better with the way existing acceptance tests are set up.

Change-Id: Ie0e30d86db9f951995110a09696decb0fc885381
This commit is contained in:
Dave Borowitz
2016-02-11 16:00:56 -05:00
parent 8bf3bbb0b8
commit 89b9bbc4d0
12 changed files with 137 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/schema/DatabaseModule.java
View File

@@ -18,7 +18,6 @@ import static com.google.inject.Scopes.SINGLETON;
import com.google.gerrit.extensions.config.FactoryModule;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.notedb.NotesMigration;
import com.google.gwtorm.jdbc.Database;
import com.google.gwtorm.server.SchemaFactory;
import com.google.inject.Key;
@@ -33,7 +32,6 @@ public class DatabaseModule extends FactoryModule {
TypeLiteral<Database<ReviewDb>> database =
new TypeLiteral<Database<ReviewDb>>() {};
bind(NotesMigration.class);
bind(schemaFactory).to(NotesMigrationSchemaFactory.class);
bind(Key.get(schemaFactory, ReviewDbFactory.class))
.to(database)