opendev/gerrit
Code Issues Proposed changes

Optimize loops in TreeFormatter

Browse Source 
In the loops that iterate over the TreeNode's do not call the size()
method on every iteration.

Change-Id: I0b9b463ab43e6defabb68ae2f0adeb4f101c93e8
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2012-01-17 09:22:37 +01:00
parent f4a57bb8d7
commit 8addcf00a7
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/TreeFormatter.java
View File

@@ -41,8 +41,9 @@ public class TreeFormatter {
} else { } else {
currentTabSeparator = DEFAULT_TAB_SEPARATOR; currentTabSeparator = DEFAULT_TAB_SEPARATOR;
int i = 0; int i = 0;
final int size = rootNodes.size();
for (final TreeNode rootNode : rootNodes) { for (final TreeNode rootNode : rootNodes) {
final boolean isLastRoot = ++i == rootNodes.size(); final boolean isLastRoot = ++i == size;
if (isLastRoot) { if (isLastRoot) {
currentTabSeparator = " "; currentTabSeparator = " ";
} }
@@ -60,8 +61,9 @@ public class TreeFormatter {
printNode(node, level, isLast); printNode(node, level, isLast);
final SortedSet<? extends TreeNode> childNodes = node.getChildren(); final SortedSet<? extends TreeNode> childNodes = node.getChildren();
int i = 0; int i = 0;
final int size = childNodes.size();
for (final TreeNode childNode : childNodes) { for (final TreeNode childNode : childNodes) {
final boolean isLastChild = ++i == childNodes.size(); final boolean isLastChild = ++i == size;
printTree(childNode, level + 1, isLastChild); printTree(childNode, level + 1, isLastChild);
} }
} }