opendev/gerrit
Code Issues Proposed changes

Fix _nextStepHandle not being assigned a value when scrolling

Browse Source 
When scrolling, _nextStepHandle is not being assigned to the async nextStep call.
This does not allow cancel() function to cancel the promise when changing files
resulting in incorrect text showing on the second file.

Bug: Issue 9409
Change-Id: I6969fdabf3c472b5a17d6901ceb2e0b19fa99921
This commit is contained in:
Dhruv Srivastava
2019-05-24 15:37:46 +02:00
parent f56144608c
commit 8c090d3f23
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
polygerrit-ui/app/elements/diff/gr-diff-processor/gr-diff-processor.js
View File

@@ -151,7 +151,7 @@
let currentBatch = 0; let currentBatch = 0;
const nextStep = () => { const nextStep = () => {
if (this._isScrolling) { if (this._isScrolling) {
this.async(nextStep, 100); this._nextStepHandle = this.async(nextStep, 100);
return; return;
} }
// If we are done, resolve the promise. // If we are done, resolve the promise.