opendev/gerrit
Code Issues Proposed changes

Honor toogleWipState permission for %ready %wip push options

Browse Source 
When toogleWipState permission was implemented these push options were
forgotten:
* 6def400 Add new change permission: Toggle Work In Progress state

Bug: Issue 13775
Change-Id: I98fc845b6f93b4a6eeff9eba86c3f246b724400d
This commit is contained in:
Sven Selberg
2020-12-03 13:40:11 +01:00
parent 7a7b57641b
commit 8c27f62954
3 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
javatests/com/google/gerrit/acceptance/git/AbstractPushForReview.java
View File

@@ -900,7 +900,19 @@ public abstract class AbstractPushForReview extends AbstractDaemonTest {
GitUtil.fetch(user2Repo, r.getPatchSet().refName() + ":ps");
user2Repo.reset("ps");
r = amendChange(r.getChangeId(), "refs/for/master%ready", user2, user2Repo);
r.assertErrorStatus(ReceiveConstants.ONLY_CHANGE_OWNER_OR_PROJECT_OWNER_CAN_MODIFY_WIP);
r.assertErrorStatus(ReceiveConstants.ONLY_USERS_WITH_TOGGLE_WIP_STATE_PERM_CAN_MODIFY_WIP);
// Non owner, non admin and non project owner with toggleWipState should succeed.
projectOperations
.project(project)
.forUpdate()
.add(
allow(Permission.TOGGLE_WORK_IN_PROGRESS_STATE)
.ref(RefNames.REFS_HEADS + "*")
.group(REGISTERED_USERS))
.update();
r = amendChange(r.getChangeId(), "refs/for/master%ready", user2, user2Repo);
r.assertOkStatus();
// Project owner trying to move from WIP to ready should succeed.
projectOperations