opendev/gerrit
Code Issues Proposed changes

Update gr-select for Polymer 2

Browse Source 
Polymer2 does not support type extension. As such, elements that rely on
it are  updated.

Instead of
<select is="gr-select"><select>

This will now be..
<gr-select>
  <select></select>
</gr-select>

This is similar to the implementation of iron-input, except that is more
complex, as it is supporting both type extention and non-type extension.
https://github.com/PolymerElements/iron-input/blob/master/iron-input.html

Bug: Issue 6371
Change-Id: I31091ff24791a9dc073b3325c7b0daa1580b69ef
This commit is contained in:
Becky Siegel
2017-07-05 14:12:44 -07:00
parent 7013809fee
commit 8e174ab23a
15 changed files with 266 additions and 245 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html
View File

@@ -454,24 +454,25 @@ limitations under the License.
<label class="patchSelectLabel" for="patchSetSelect">
Patch set
</label>
<select
is="gr-select"
<gr-select
id="patchSetSelect"
bind-value="{{_selectedPatchSet}}"
class="patchSetSelect"
on-change="_handlePatchChange">
<template is="dom-repeat" items="[[_allPatchSets]]"
as="patchNum">
<option value$="[[patchNum.num]]"
disabled$="[[_computePatchSetDisabled(patchNum.num, _patchRange.basePatchNum)]]">
[[patchNum.num]]
/
[[computeLatestPatchNum(_allPatchSets)]]
[[_computePatchSetCommentsString(_comments, patchNum.num)]]
[[_computePatchSetDescription(_change, patchNum.num)]]
</option>
</template>
</select>
<select>
<template is="dom-repeat" items="[[_allPatchSets]]"
as="patchNum">
<option value$="[[patchNum.num]]"
disabled$="[[_computePatchSetDisabled(patchNum.num, _patchRange.basePatchNum)]]">
[[patchNum.num]]
/
[[computeLatestPatchNum(_allPatchSets)]]
[[_computePatchSetCommentsString(_comments, patchNum.num)]]
[[_computePatchSetDescription(_change, patchNum.num)]]
</option>
</template>
</select>
</gr-select>
/
<gr-commit-info
change="[[_change]]"