opendev/gerrit
Code Issues Proposed changes

Merge "ChangeScreen2: Fix position of ReplyBox"

Browse Source
This commit is contained in:
Shawn Pearce
2013-12-08 17:37:30 +00:00
committed by Gerrit Code Review
parent ee87a6fb42 f90bcdc7af
commit 8e19090765
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java
View File

@@ -23,6 +23,7 @@ import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gwt.core.client.JsArrayString; import com.google.gwt.core.client.JsArrayString;
import com.google.gwt.event.logical.shared.CloseEvent; import com.google.gwt.event.logical.shared.CloseEvent;
import com.google.gwt.event.logical.shared.CloseHandler; import com.google.gwt.event.logical.shared.CloseHandler;
import com.google.gwt.user.client.Window;
import com.google.gwt.user.client.ui.PopupPanel; import com.google.gwt.user.client.ui.PopupPanel;
import com.google.gwt.user.client.ui.Widget; import com.google.gwt.user.client.ui.Widget;
import com.google.gwtexpui.globalkey.client.GlobalKey; import com.google.gwtexpui.globalkey.client.GlobalKey;
@@ -101,6 +102,7 @@ class ReplyAction {
} }
}); });
p.add(replyBox); p.add(replyBox);
Window.scrollTo(0, 0);
p.showRelativeTo(replyButton); p.showRelativeTo(replyButton);
GlobalKey.dialog(p); GlobalKey.dialog(p);
popup = p; popup = p;

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java
View File

@@ -49,7 +49,6 @@ import com.google.gwt.resources.client.CssResource;
import com.google.gwt.uibinder.client.UiBinder; import com.google.gwt.uibinder.client.UiBinder;
import com.google.gwt.uibinder.client.UiField; import com.google.gwt.uibinder.client.UiField;
import com.google.gwt.uibinder.client.UiHandler; import com.google.gwt.uibinder.client.UiHandler;
import com.google.gwt.user.client.Window;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.Button;
import com.google.gwt.user.client.ui.CheckBox; import com.google.gwt.user.client.ui.CheckBox;
@@ -154,7 +153,6 @@ class ReplyBox extends Composite {
Scheduler.get().scheduleDeferred(new ScheduledCommand() { Scheduler.get().scheduleDeferred(new ScheduledCommand() {
@Override @Override
public void execute() { public void execute() {
Window.scrollTo(0, 0);
message.setFocus(true); message.setFocus(true);
}}); }});
Scheduler.get().scheduleFixedDelay(new RepeatingCommand() { Scheduler.get().scheduleFixedDelay(new RepeatingCommand() {