opendev/gerrit
Code Issues Proposed changes

Restore: Use BooleanCondition for #setVisible

Browse Source 
Change-Id: I4d5eb0a36dbdd9df086de7cc1ec1948989e95318
This commit is contained in:
Patrick Hiesel
2017-08-16 16:53:43 +02:00
parent 2c76a76449
commit 8e838fabb5
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gerrit-server/src/main/java/com/google/gerrit/server/change/Restore.java
View File

@@ -14,6 +14,8 @@
package com.google.gerrit.server.change;
import static com.google.gerrit.extensions.conditions.BooleanCondition.and;
import com.google.common.base.Strings;
import com.google.gerrit.common.TimeUtil;
import com.google.gerrit.extensions.api.changes.RestoreInput;
@@ -156,7 +158,8 @@ public class Restore extends RetryingRestModifyView<ChangeResource, RestoreInput
.setLabel("Restore")
.setTitle("Restore the change")
.setVisible(
rsrc.getChange().getStatus() == Status.ABANDONED
&& rsrc.permissions().database(dbProvider).testOrFalse(ChangePermission.RESTORE));
and(
rsrc.getChange().getStatus() == Status.ABANDONED,
rsrc.permissions().database(dbProvider).testCond(ChangePermission.RESTORE)));
}
}