From 8eefe46f060a2aac20e71fc0a22374490dc6bfcf Mon Sep 17 00:00:00 2001 From: David Ostrovsky Date: Thu, 6 Jul 2017 06:53:24 +0200 Subject: [PATCH] Document Eclipse's warning free code policy Change-Id: I0429d00d693619cc56cb84d845ff1fe454441971 --- Documentation/dev-contributing.txt | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Documentation/dev-contributing.txt b/Documentation/dev-contributing.txt index e4a7218268..4c1df8c8ca 100644 --- a/Documentation/dev-contributing.txt +++ b/Documentation/dev-contributing.txt @@ -147,6 +147,17 @@ Password tab of the user settings page]. [[style]] === Style +This project has a policy of Eclipse's warning free code. Eclipse +configuration is added to git and we expect the changes to be +warnings free. + +We do not ask you to use Eclipse for editing, obviously. We do ask you +to provide Eclipse's warning free patches only. If for some reasons, you +are not able to set up Eclipse and verify, that your patch hasn't +introduced any new Eclipse warnings, mention this in a comment to your +change, so that reviewers will do it for you. Yes, the way to go is to +extend gerrit CI to take care of this, but it's not yet implemented. + Gerrit generally follows the link:https://google.github.io/styleguide/javaguide.html[Google Java Style Guide].