opendev/gerrit
Code Issues Proposed changes

Ensure NotesMigration method calls aren't cached

Browse Source 
This will soon no longer be an immutable singleton read at startup, so
we shouldn't store the results of method calls in other singletons'
constructors.

Change-Id: I22ef7111586a84d71413876d451611bc8d93b6c6
This commit is contained in:
Dave Borowitz
2016-02-11 16:06:27 -05:00
parent 89b9bbc4d0
commit 8f5db32405
3 changed files with 11 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-server/src/main/java/com/google/gerrit/server/Sequences.java
View File

@@ -37,12 +37,8 @@ public class Sequences {
AllProjectsName allProjects) {
this.db = db;
this.migration = migration;
if (migration.readChanges()) {
changeSeq = new RepoSequence(
repoManager, allProjects, "changes", ReviewDb.FIRST_CHANGE_ID, 100);
} else {
changeSeq = null;
}
changeSeq = new RepoSequence(
repoManager, allProjects, "changes", ReviewDb.FIRST_CHANGE_ID, 100);
}
@SuppressWarnings("deprecation")