opendev/gerrit
Code Issues Proposed changes

Add query tests for filtering/restarting paginated queries

Browse Source 
Change-Id: Ifd8950cb3a2ed72ef19d611f5e5d51f2a03ce097
This commit is contained in:
Dave Borowitz
2013-10-16 12:46:12 -07:00
parent a475bedc29
commit 8f6bb178b6
1 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
gerrit-server/src/test/java/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java
View File

@@ -540,6 +540,34 @@ public abstract class AbstractQueryChangesTest {
assertResultEquals(change1, results.get(1)); assertResultEquals(change1, results.get(1));
} }
@Test
public void filterOutMoreThanOnePageOfResults() throws Exception {
TestRepository<InMemoryRepository> repo = createProject("repo");
Change change = newChange(repo, null, null, userId.get(), null).insert();
int user2 = accountManager.authenticate(AuthRequest.forUser("anotheruser"))
.getAccountId().get();
for (int i = 0; i < 5; i++) {
newChange(repo, null, null, user2, null).insert();
}
assertResultEquals(change, queryOne("status:new ownerin:Administrators"));
assertResultEquals(change,
queryOne("status:new ownerin:Administrators limit:2"));
}
@Test
public void filterOutAllResults() throws Exception {
TestRepository<InMemoryRepository> repo = createProject("repo");
int user2 = accountManager.authenticate(AuthRequest.forUser("anotheruser"))
.getAccountId().get();
for (int i = 0; i < 5; i++) {
newChange(repo, null, null, user2, null).insert();
}
assertTrue(query("status:new ownerin:Administrators").isEmpty());
assertTrue(query("status:new ownerin:Administrators limit:2").isEmpty());
}
protected ChangeInserter newChange( protected ChangeInserter newChange(
TestRepository<InMemoryRepository> repo, TestRepository<InMemoryRepository> repo,
@Nullable RevCommit commit, @Nullable String key, @Nullable Integer owner, @Nullable RevCommit commit, @Nullable String key, @Nullable Integer owner,