Bump guava version to 18.0

New version fixes 16 bugs and includes some API changes [1].
MoreExecutors.directExecutor() is now the new lightweight version
of now deprecated sameThreadExecutor().

[1] https://code.google.com/p/guava-libraries/wiki/Release18

Change-Id: I98dbf951b82095504272cc90f1468652621ae2bd

gerrit-pgm/src/main/java/com/google/gerrit/pgm/RebuildNotedb.java

@@ -130,7 +130,7 @@ public class RebuildNotedb extends SiteProgram {
             futures.add(future);
             future.addListener(
                 new RebuildListener(c.getId(), future, ok, doneTask, failedTask),
-                MoreExecutors.sameThreadExecutor());
+                MoreExecutors.directExecutor());
           }
 
           mpm.waitFor(Futures.transform(Futures.successfulAsList(futures),
@@ -212,7 +212,7 @@ public class RebuildNotedb extends SiteProgram {
           dbInjector.getInstance(WorkQueue.class)
             .createQueue(threads, "RebuildChange"));
     } else {
-      return MoreExecutors.sameThreadExecutor();
+      return MoreExecutors.newDirectExecutorService();
     }
   }
 

gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommitsExecutorModule.java

@@ -60,7 +60,7 @@ public class ReceiveCommitsExecutorModule extends AbstractModule {
   public ListeningExecutorService createChangeUpdateExecutor(@GerritServerConfig Config config) {
     int poolSize = config.getInt("receive", null, "changeUpdateThreads", 1);
     if (poolSize <= 1) {
-      return MoreExecutors.sameThreadExecutor();
+      return MoreExecutors.newDirectExecutorService();
     }
     return MoreExecutors.listeningDecorator(
         MoreExecutors.getExitingExecutorService(

gerrit-server/src/main/java/com/google/gerrit/server/index/ChangeBatchIndexer.java

@@ -195,7 +195,7 @@ public class ChangeBatchIndexer {
           fail(project, e);
           throw e;
         }
-      }, MoreExecutors.sameThreadExecutor());
+      }, MoreExecutors.directExecutor());
     }
 
     try {

gerrit-server/src/main/java/com/google/gerrit/server/index/IndexModule.java

@@ -106,7 +106,7 @@ public class IndexModule extends LifecycleModule {
         threads = config.getInt("index", null, "threads", 0);
       }
       if (threads <= 0) {
-        return MoreExecutors.sameThreadExecutor();
+        return MoreExecutors.newDirectExecutorService();
       }
       return MoreExecutors.listeningDecorator(
           workQueue.createQueue(threads, "index"));

lib/BUCK

@@ -51,8 +51,8 @@ maven_jar(
 
 maven_jar(
   name = 'guava',
-  id = 'com.google.guava:guava:17.0',
-  sha1 = '9c6ef172e8de35fd8d4d8783e4821e57cdef7445',
+  id = 'com.google.guava:guava:18.0',
+  sha1 = 'cce0823396aa693798f8882e64213b1772032b09',
   license = 'Apache2.0',
 )