opendev/gerrit
Code Issues Proposed changes

SideBySide2: Rearrange order of ? help popup

Browse Source 
Display the box as:

  Application           Actions

  Navigation

                        Comment Editing

Given the length of the Navigation and Actions lists, this fits
much better into the dialog and avoids vast amounts of empty space.

Change-Id: Ie4d23f706ccdfe3f96bbbb4adc87c1ee8c5ac506
This commit is contained in:
Shawn Pearce
2014-04-24 12:45:18 -07:00
parent 4048817429
commit 90dc5a443d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySide2.java
View File

@@ -471,11 +471,11 @@ public class SideBySide2 extends Screen {
} }
removeKeyHandlerRegistrations(); removeKeyHandlerRegistrations();
handlers.add(GlobalKey.add(this, keysAction));
handlers.add(GlobalKey.add(this, keysNavigation)); handlers.add(GlobalKey.add(this, keysNavigation));
if (keysComment != null) { if (keysComment != null) {
handlers.add(GlobalKey.add(this, keysComment)); handlers.add(GlobalKey.add(this, keysComment));
} }
handlers.add(GlobalKey.add(this, keysAction));
handlers.add(ShowHelpCommand.addFocusHandler(new FocusHandler() { handlers.add(ShowHelpCommand.addFocusHandler(new FocusHandler() {
@Override @Override
public void onFocus(FocusEvent event) { public void onFocus(FocusEvent event) {