opendev/gerrit
Code Issues Proposed changes

GetPureRevert: Remove declaration of unthrown AuthException

Browse Source 
Change-Id: I4e1414f5551cf4185d6938d3f9449934012a699e
This commit is contained in:
David Pursehouse
2017-09-14 08:19:44 +09:00
parent 1a48326504
commit 91009aac3c
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-server/src/main/java/com/google/gerrit/server/change/GetPureRevert.java
View File

@@ -97,8 +97,7 @@ public class GetPureRevert implements RestReadView<ChangeResource> {
}
public PureRevertInfo getPureRevert(ChangeNotes notes)
throws OrmException, IOException, BadRequestException, AuthException,
ResourceConflictException {
throws OrmException, IOException, BadRequestException, ResourceConflictException {
PatchSet currentPatchSet = psUtil.current(dbProvider.get(), notes);
if (currentPatchSet == null) {
throw new ResourceConflictException("current revision is missing");

3
gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeData.java
View File

@@ -35,7 +35,6 @@ import com.google.gerrit.common.Nullable;
import com.google.gerrit.common.data.LabelTypes;
import com.google.gerrit.common.data.SubmitRecord;
import com.google.gerrit.common.data.SubmitTypeRecord;
import com.google.gerrit.extensions.restapi.AuthException;
import com.google.gerrit.extensions.restapi.BadRequestException;
import com.google.gerrit.extensions.restapi.ResourceConflictException;
import com.google.gerrit.reviewdb.client.Account;
@@ -1288,7 +1287,7 @@ public class ChangeData {
}
try {
return pureRevert.getPureRevert(notes()).isPureRevert;
} catch (IOException | BadRequestException | AuthException | ResourceConflictException e) {
} catch (IOException | BadRequestException | ResourceConflictException e) {
throw new OrmException("could not compute pure revert", e);
}
}