opendev/gerrit
Code Issues Proposed changes

ChangeScreen2: Display revision after posting review

Browse Source 
Instead of displaying the current revision display the revision
the review was commenting on. This keeps the UI roughly static,
but updates the change history at the bottom of the screen.

Change-Id: I67453230fd60fb6e57feb86293cdd9c6526d6a32
This commit is contained in:
Shawn Pearce
2013-08-20 21:48:37 -07:00
parent 8ab132bf31
commit 912c065be6
2 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java
View File

@@ -17,7 +17,7 @@ package com.google.gerrit.client.change;
import com.google.gerrit.client.changes.ChangeInfo;
import com.google.gerrit.client.changes.ChangeInfo.LabelInfo;
import com.google.gerrit.client.rpc.NativeMap;
import com.google.gerrit.reviewdb.client.Change;
import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gwt.core.client.JsArrayString;
import com.google.gwt.event.logical.shared.CloseEvent;
import com.google.gwt.event.logical.shared.CloseHandler;
@@ -27,7 +27,7 @@ import com.google.gwtexpui.globalkey.client.GlobalKey;
import com.google.gwtexpui.user.client.PluginSafePopupPanel;
class ReplyAction {
private final Change.Id changeId;
private final PatchSet.Id psId;
private final String revision;
private final ChangeScreen2.Style style;
private final Widget replyButton;
@@ -43,7 +43,9 @@ class ReplyAction {
String revision,
ChangeScreen2.Style style,
Widget replyButton) {
this.changeId = info.legacy_id();
this.psId = new PatchSet.Id(
info.legacy_id(),
info.revisions().get(revision)._number());
this.revision = revision;
this.style = style;
this.replyButton = replyButton;
@@ -63,7 +65,7 @@ class ReplyAction {
if (replyBox == null) {
replyBox = new ReplyBox(
changeId,
psId,
revision,
allLabels,
permittedLabels);