From 91c8c1e35eaa31ba71ec8cfc7438efb0f7f48db3 Mon Sep 17 00:00:00 2001 From: Shawn Pearce Date: Mon, 6 Jun 2016 12:41:56 -0700 Subject: [PATCH] Don't format webLinks for parent commits Post fd6b98143759ed38d9682b4127903def4e09f541 ("Don't show PatchSetWebLink for parent commits") the web UI does not use patch set web links for the parent commits. These are parent commits, they are not necessarily a patch set under review, and should not get links formatted by the PatchSetWebLinks. Change-Id: Ib2babb8a4c9599fda1d6282cb0c6efdc349c0ae5 --- .../java/com/google/gerrit/server/change/ChangeJson.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java index df23e9ac3a..c9a0d11465 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java @@ -1004,11 +1004,6 @@ public class ChangeJson { CommitInfo i = new CommitInfo(); i.commit = parent.name(); i.subject = parent.getShortMessage(); - if (addLinks) { - FluentIterable parentLinks = - webLinks.getPatchSetLinks(project, parent.name()); - i.webLinks = parentLinks.isEmpty() ? null : parentLinks.toList(); - } info.parents.add(i); } return info;