opendev/gerrit
Code Issues Proposed changes

Inject AllProjectsName directly instead of through AllProjectsNameProvider

Browse Source 
It's not necessary to inject the provider.

SchemaModule binds AllProjectsName to AllProjectsNameProvider, which means
if you @Inject an AllProjectsName, it looks up the Provider<AllProjectsName>
in the injector's provider map, then calls get() on the resulting provider
to get an instance.

Also make AllProjectsNameProvider a Singleton.

Change-Id: Ie6156afa1d7e5edaff2f922df54d9aa143b13efc
This commit is contained in:
David Pursehouse
2016-02-21 21:52:52 +09:00
parent f2ff1a395d
commit 91ef0badae
9 changed files with 25 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-server/src/main/java/com/google/gerrit/server/project/PutConfig.java
View File

@@ -32,7 +32,7 @@ import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.reviewdb.client.RefNames;
import com.google.gerrit.server.CurrentUser;
import com.google.gerrit.server.EnableSignedPush;
import com.google.gerrit.server.config.AllProjectsNameProvider;
import com.google.gerrit.server.config.AllProjectsName;
import com.google.gerrit.server.config.PluginConfig;
import com.google.gerrit.server.config.PluginConfigFactory;
import com.google.gerrit.server.config.ProjectConfigEntry;
@@ -86,7 +86,7 @@ public class PutConfig implements RestModifyView<ProjectResource, Input> {
private final TransferConfig config;
private final DynamicMap<ProjectConfigEntry> pluginConfigEntries;
private final PluginConfigFactory cfgFactory;
private final AllProjectsNameProvider allProjects;
private final AllProjectsName allProjects;
private final DynamicMap<RestView<ProjectResource>> views;
private final Provider<CurrentUser> user;
private final ChangeHooks hooks;
@@ -101,7 +101,7 @@ public class PutConfig implements RestModifyView<ProjectResource, Input> {
TransferConfig config,
DynamicMap<ProjectConfigEntry> pluginConfigEntries,
PluginConfigFactory cfgFactory,
AllProjectsNameProvider allProjects,
AllProjectsName allProjects,
DynamicMap<RestView<ProjectResource>> views,
ChangeHooks hooks,
GitReferenceUpdated gitRefUpdated,