opendev/gerrit
Code Issues Proposed changes

gerrit_plugin: Don't add Implementation-Vendor manifest entry

Browse Source 
If a plugin specifies Implementation-Vendor, adding it again in the
gerrit_plugin rule results in a duplicate entry and the following
warning at build time:

  WARNING: Duplicate name in Manifest: Implementation-Vendor.
  Ensure that the manifest does not have duplicate entries, and
  that blank lines separate individual sections in both your
  manifest and in the META-INF/MANIFEST.MF entry in the jar file.

This change is the same as done in bazlets project by David Ostrovsky.

Change-Id: Iac72c1d1dbe11877e4e2042d2e11c8966147d7a9
This commit is contained in:
Hector Oswaldo Caballero 2017-12-15 06:25:11 -05:00
parent 7e065fc845
commit 92a34d0b6c
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/bzl/plugin.bzl
View File

@ -44,10 +44,7 @@ def gerrit_plugin(
native.java_binary( native.java_binary(
name = '%s__non_stamped' % name, name = '%s__non_stamped' % name,
deploy_manifest_lines = manifest_entries + [ deploy_manifest_lines = manifest_entries + ["Gerrit-ApiType: plugin"],
"Gerrit-ApiType: plugin",
"Implementation-Vendor: Gerrit Code Review",
],
main_class = 'Dummy', main_class = 'Dummy',
runtime_deps = [ runtime_deps = [
':%s__plugin' % name, ':%s__plugin' % name,