opendev/gerrit
Code Issues Proposed changes

Fix NPE computing ChangeInfo.removable_reviewers

Browse Source 
Change-Id: Iaaf78f70c7671d2bf5c8e73611f4d64eab1c4b84
This commit is contained in:
Dave Borowitz
2013-02-27 11:04:02 -08:00
parent c0c65891a6
commit 9328c64187
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java
View File

@@ -590,6 +590,9 @@ public class ChangeJson {
Set<Account.Id> fixed = Sets.newHashSetWithExpectedSize(labels.size());
Set<Account.Id> removable = Sets.newHashSetWithExpectedSize(labels.size());
for (LabelInfo label : labels) {
if (label.all == null) {
continue;
}
for (ApprovalInfo ai : label.all) {
if (ctl.canRemoveReviewer(ai._id, ai.value)) {
removable.add(ai._id);