opendev/gerrit
Code Issues Proposed changes

Make DownloadScheme.isAuthSupported an abstract method

Browse Source 
It is too easy to forget to override isAuthSupported in download
schemes that support but do not require authentication.  Make it
abstract so anyone adding a new download scheme has to make an
explicit choice about whether it should show up on changes that are
not world-readable.

Change-Id: Ifbc70c0d3b6eea08ceee726317381cabd3892e03
This commit is contained in:
Jonathan Nieder
2013-10-31 14:42:01 -07:00
parent 5d7a8decfe
commit 935ce8afdc
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/config/DownloadScheme.java
View File

@@ -30,9 +30,7 @@ public abstract class DownloadScheme {
public abstract boolean isAuthRequired(); public abstract boolean isAuthRequired();
/** @return whether this scheme supports authentication */ /** @return whether this scheme supports authentication */
public boolean isAuthSupported() { public abstract boolean isAuthSupported();
return isAuthRequired();
}
/** @return whether the download scheme is enabled */ /** @return whether the download scheme is enabled */
public abstract boolean isEnabled(); public abstract boolean isEnabled();

2
plugins/download-commands

Submodule plugins/download-commands updated: fbec6d1a66...fe2bc6be5e