diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/patch/PatchScriptBuilder.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/patch/PatchScriptBuilder.java index 30d771602c..2604d92609 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/patch/PatchScriptBuilder.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/patch/PatchScriptBuilder.java @@ -139,7 +139,8 @@ class PatchScriptBuilder { if (intralineDifference) { if (isModify(content)) { - IntraLineDiff d = patchListCache.get(a.id, a.src, b.id, b.src, edits); + IntraLineDiff d = + patchListCache.getIntraLineDiff(a.id, a.src, b.id, b.src, edits); if (d != null) { edits = new ArrayList(d.getEdits()); } else { diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCache.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCache.java index c679f4af80..c7bb08b4c8 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCache.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCache.java @@ -16,7 +16,6 @@ package com.google.gerrit.server.patch; import com.google.gerrit.reviewdb.Change; import com.google.gerrit.reviewdb.PatchSet; -import com.google.gerrit.reviewdb.AccountDiffPreference.Whitespace; import org.eclipse.jgit.diff.Edit; import org.eclipse.jgit.lib.ObjectId; @@ -29,8 +28,6 @@ public interface PatchListCache { public PatchList get(Change change, PatchSet patchSet); - public PatchList get(Change change, PatchSet patchSet, Whitespace whitespace); - - public IntraLineDiff get(ObjectId aId, Text aText, ObjectId bId, Text bText, - List edits); + public IntraLineDiff getIntraLineDiff(ObjectId aId, Text aText, ObjectId bId, + Text bText, List edits); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCacheImpl.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCacheImpl.java index 29b5799e50..285420c9e6 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCacheImpl.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListCacheImpl.java @@ -90,20 +90,16 @@ public class PatchListCacheImpl implements PatchListCache { } public PatchList get(final Change change, final PatchSet patchSet) { - return get(change, patchSet, Whitespace.IGNORE_NONE); - } - - public PatchList get(final Change change, final PatchSet patchSet, - final Whitespace whitespace) { final Project.NameKey projectKey = change.getProject(); final ObjectId a = null; final ObjectId b = ObjectId.fromString(patchSet.getRevision().get()); - return get(new PatchListKey(projectKey, a, b, whitespace)); + final Whitespace ws = Whitespace.IGNORE_NONE; + return get(new PatchListKey(projectKey, a, b, ws)); } @Override - public IntraLineDiff get(ObjectId aId, Text aText, ObjectId bId, Text bText, - List edits) { + public IntraLineDiff getIntraLineDiff(ObjectId aId, Text aText, ObjectId bId, + Text bText, List edits) { if (computeIntraline) { IntraLineDiffKey key = new IntraLineDiffKey(aId, aText, bId, bText, edits);