opendev/gerrit
Code Issues Proposed changes

Give full names to 'r' and 'l' options on magic branch input

Browse Source 
Changes the names to '--review' and '--label' and add '-r' and '-l'
as aliases.

Change-Id: I54a7b15151c74193c2bd8324e87a5857babe3080
This commit is contained in:
David Pursehouse
2014-10-03 12:26:04 +09:00
parent 28f9280d01
commit 93733b601f
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Documentation/user-upload.txt
View File

@@ -155,8 +155,8 @@ updates:
git push ssh://john.doe@git.example.com:29418/kernel/common HEAD:refs/for/experimental%topic=driver/i42
====
Review labels can be applied to the change by using the -l option
in the reference:
Review labels can be applied to the change by using the `label` (or `l`)
option in the reference:
====
git push ssh://john.doe@git.example.com:29418/kernel/common HEAD:refs/for/experimental%l=Verified+1
@@ -185,8 +185,8 @@ shorter URLs on the command line, such as:
====
Specific reviewers can be requested and/or additional 'carbon
copies' of the notification message may be sent by including these
as options in the reference
copies' of the notification message may be sent by including the
`reviewer` (or `r`) and `cc` options in the reference:
====
git push tr:kernel/common HEAD:refs/for/experimental%r=a@a.com,cc=b@o.com

5
gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
View File

@@ -1131,7 +1131,8 @@ public class ReceiveCommits {
@Option(name = "--submit", usage = "immediately submit the change")
boolean submit;
@Option(name = "-r", metaVar = "EMAIL", usage = "add reviewer to changes")
@Option(name = "--reviewer", aliases = {"-r"}, metaVar = "EMAIL",
usage = "add reviewer to changes")
void reviewer(Account.Id id) {
reviewer.add(id);
}
@@ -1146,7 +1147,7 @@ public class ReceiveCommits {
draft = !publish;
}
@Option(name = "-l", metaVar = "LABEL+VALUE",
@Option(name = "--label", aliases = {"-l"}, metaVar = "LABEL+VALUE",
usage = "label(s) to assign (defaults to +1 if no value provided")
void addLabel(final String token) throws CmdLineException {
LabelVote v = LabelVote.parse(token);