opendev/gerrit
Code Issues Proposed changes

Post/Delete GPG keys: Remove incorrect comments

Browse Source 
Originally this change was based on change Ie5ff96a0c which handles
LOCK_FAILURE in PublicKeyStore#save, but since this change was rebased
out of the series the comments regarding LOCK_FAILURE are not correct
and should be dropped.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ic2406c1f32698dd9f1d725e09bff477fb7b606e3
This commit is contained in:
Edwin Kempin
2019-11-11 11:27:32 +01:00
parent f6aa2df3cf
commit 942a39cd53
2 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/com/google/gerrit/gpg/server/DeleteGpgKey.java
View File

@@ -109,7 +109,6 @@ public class DeleteGpgKey implements RestModifyView<GpgKey, Input> {
} }
break; break;
case LOCK_FAILURE: case LOCK_FAILURE:
// should not happen since this case is already handled by PublicKeyStore#save
case FORCED: case FORCED:
case IO_FAILURE: case IO_FAILURE:
case NEW: case NEW:

1
java/com/google/gerrit/gpg/server/PostGpgKeys.java
View File

@@ -250,7 +250,6 @@ public class PostGpgKeys implements RestModifyView<AccountResource, GpgKeysInput
case NO_CHANGE: case NO_CHANGE:
break; break;
case LOCK_FAILURE: case LOCK_FAILURE:
// should not happen since this case is already handled by PublicKeyStore#save
case IO_FAILURE: case IO_FAILURE:
case NOT_ATTEMPTED: case NOT_ATTEMPTED:
case REJECTED: case REJECTED: