opendev/gerrit
Code Issues Proposed changes

Remove usage of GerritConfig from GitWebServlet

Browse Source 
Instead of injecting GerritConfig into GitWebServlet inject what is
needed to get the SSHD listen address and the canonical git URL, since
this is everything GitWebServlet needs. Removing the injection of
GerritConfig allows us to remove the SSHD listen address and the
canonical git URL from GerritConfig and in a later step to get rid of
GerritConfig.

Change-Id: I74c134edb34a26a49424c4ee1337dab642c249f3
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2015-05-12 14:02:18 +02:00
parent 545a3db32b
commit 9480fb45b9
3 changed files with 19 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
gerrit-common/src/main/java/com/google/gerrit/common/data/GerritConfig.java
View File

@@ -16,29 +16,8 @@ package com.google.gerrit.common.data;
public class GerritConfig implements Cloneable {
protected String gitDaemonUrl;
protected String sshdAddress;
protected boolean documentationAvailable;
public String getGitDaemonUrl() {
return gitDaemonUrl;
}
public void setGitDaemonUrl(String url) {
if (url != null && !url.endsWith("/")) {
url += "/";
}
gitDaemonUrl = url;
}
public String getSshdAddress() {
return sshdAddress;
}
public void setSshdAddress(final String addr) {
sshdAddress = addr;
}
public boolean isDocumentationAvailable() {
return documentationAvailable;
}