opendev/gerrit
Code Issues Proposed changes

Merge "Add a param for added reviewers on reply-reviewers endpoint"

Browse Source
This commit is contained in:
Tao Zhou
2020-07-14 13:27:18 +00:00
committed by Gerrit Code Review
parent 5218782564 ba5714b0c8
commit 94fa835e8f
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js
View File

@@ -285,6 +285,15 @@ class GrReplyDialog extends KeyboardShortcutMixin(GestureEventListeners(
type: Boolean, type: Boolean,
value: true, value: true,
}, },
/**
* A copy of added reviewers, a new copy is created when any change
* made to the reviewers.
*/
_allReviewers: {
type: Array,
computed: '_computeAllReviewers(_reviewers.*)',
},
}; };
} }
@@ -1102,6 +1111,10 @@ class GrReplyDialog extends KeyboardShortcutMixin(GestureEventListeners(
} }
this.reporting.reportInteraction('attention-set-actions', {actions}); this.reporting.reportInteraction('attention-set-actions', {actions});
} }
_computeAllReviewers() {
return [...this._reviewers];
}
} }
customElements.define(GrReplyDialog.is, GrReplyDialog); customElements.define(GrReplyDialog.is, GrReplyDialog);

2
polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog_html.js
View File

@@ -178,6 +178,8 @@ export const htmlTemplate = html`
<section class="peopleContainer"> <section class="peopleContainer">
<gr-endpoint-decorator name="reply-reviewers"> <gr-endpoint-decorator name="reply-reviewers">
<gr-endpoint-param name="change" value="[[change]]"></gr-endpoint-param> <gr-endpoint-param name="change" value="[[change]]"></gr-endpoint-param>
<gr-endpoint-param name="reviewers" value="[[_allReviewers]]">
</gr-endpoint-param>
<div class="peopleList"> <div class="peopleList">
<div class="peopleListLabel">Reviewers</div> <div class="peopleListLabel">Reviewers</div>
<gr-account-list <gr-account-list