opendev/gerrit
Code Issues Proposed changes

Remove usage of to-be-deprecated GWT DOM helper methods

Browse Source 
These are not all currently deprecated, but are deprecated in GWT
master, e.g.:
https://gwt.googlesource.com/gwt/+/a6044a4a54c352b2709d27dd1907e977ce1607ad

This change was produced with an automated tool courtesy of the GWT
team.

Change-Id: Ie5401a3e2231bad7099c4ff35e2c64d77cbbb33b
This commit is contained in:
Dave Borowitz
2013-10-02 10:36:39 -07:00
parent cdae61f015
commit 9577768bf4
17 changed files with 24 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ChangeLink.java
View File

@@ -20,7 +20,6 @@ import com.google.gerrit.common.data.ChangeInfo;
import com.google.gerrit.reviewdb.client.Change;
import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gwt.core.client.GWT;
import com.google.gwt.user.client.DOM;
public class ChangeLink extends InlineHyperlink {
public static String permalink(final Change.Id c) {
@@ -32,7 +31,7 @@ public class ChangeLink extends InlineHyperlink {
public ChangeLink(final String text, final Change.Id c) {
super(text, PageLinks.toChange(c));
DOM.setElementProperty(getElement(), "href", permalink(c));
getElement().setPropertyString("href", permalink(c));
cid = c;
psid = null;
}

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CherryPickDialog.java
View File

@@ -22,7 +22,6 @@ import com.google.gerrit.client.rpc.GerritCallback;
import com.google.gerrit.client.rpc.Natives;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gwt.core.client.JsArray;
import com.google.gwt.user.client.DOM;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.FocusWidget;
import com.google.gwt.user.client.ui.SuggestBox;
@@ -63,7 +62,7 @@ public abstract class CherryPickDialog extends ActionDialog {
});
newBranch.setWidth("100%");
DOM.setStyleAttribute(newBranch.getElement(), "boxSizing", "border-box");
newBranch.getElement().getStyle().setProperty("boxSizing", "border-box");
message.setCharacterWidth(70);
final FlowPanel mwrap = new FlowPanel();

7
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommentedActionDialog.java
View File

@@ -21,7 +21,6 @@ import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwt.event.logical.shared.CloseEvent;
import com.google.gwt.event.logical.shared.CloseHandler;
import com.google.gwt.user.client.DOM;
import com.google.gwtjsonrpc.common.AsyncCallback;
import com.google.gwt.user.client.ui.Button;
import com.google.gwt.user.client.ui.FlowPanel;
@@ -55,7 +54,7 @@ public abstract class CommentedActionDialog<T> extends AutoCenterDialogBox
message = new NpTextArea();
message.setCharacterWidth(60);
message.setVisibleLines(10);
DOM.setElementPropertyBoolean(message.getElement(), "spellcheck", true);
message.getElement().setPropertyBoolean("spellcheck", true);
setFocusOn(message);
sendButton = new Button(Util.C.commentedActionButtonSend());
sendButton.addClickHandler(new ClickHandler() {
@@ -67,7 +66,7 @@ public abstract class CommentedActionDialog<T> extends AutoCenterDialogBox
});
cancelButton = new Button(Util.C.commentedActionButtonCancel());
DOM.setStyleAttribute(cancelButton.getElement(), "float", "right");
cancelButton.getElement().getStyle().setProperty("float", "right");
cancelButton.addClickHandler(new ClickHandler() {
@Override
public void onClick(final ClickEvent event) {
@@ -82,7 +81,7 @@ public abstract class CommentedActionDialog<T> extends AutoCenterDialogBox
buttonPanel = new FlowPanel();
buttonPanel.add(sendButton);
buttonPanel.add(cancelButton);
DOM.setStyleAttribute(buttonPanel.getElement(), "marginTop", "4px");
buttonPanel.getElement().getStyle().setProperty("marginTop", "4px");
panel = new FlowPanel();
panel.add(new SmallHeading(heading));

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/ComplexDisclosurePanel.java
View File

@@ -47,15 +47,15 @@ public class ComplexDisclosurePanel extends Composite implements
final Element tr1 = DOM.getChild(tbody, 0);
final Element tr2 = DOM.getChild(tbody, 1);
DOM.setElementProperty(DOM.getChild(tr1, 0), "width", "20px");
DOM.setElementPropertyInt(DOM.getChild(tr2, 0), "colSpan", 2);
DOM.getChild(tr1, 0).setPropertyString("width", "20px");
DOM.getChild(tr2, 0).setPropertyInt("colSpan", 2);
headerParent = tr1;
}
header = new ComplexPanel() {
{
setElement(DOM.createTD());
DOM.setInnerHTML(getElement(), "&nbsp;");
getElement().setInnerHTML("&nbsp;");
addStyleName(Gerrit.RESOURCES.css().complexHeader());
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/FancyFlexTableImplIE6.java
View File

@@ -29,7 +29,7 @@ public class FancyFlexTableImplIE6 extends FancyFlexTableImpl {
assert newBody != null;
final Element tableElem = DOM.getParent(oldBody);
DOM.removeChild(tableElem, oldBody);
tableElem.removeChild(oldBody);
setBodyElement(myTable, newBody);
DOM.appendChild(tableElem, newBody);
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/Hyperlink.java
View File

@@ -55,7 +55,7 @@ public class Hyperlink extends com.google.gwt.user.client.ui.Hyperlink {
@Override
public void onBrowserEvent(final Event event) {
if (DOM.eventGetType(event) == Event.ONCLICK && impl.handleAsClick(event)) {
DOM.eventPreventDefault(event);
event.preventDefault();
go();
} else {
super.onBrowserEvent(event);

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/InlineHyperlink.java
View File

@@ -40,7 +40,7 @@ public class InlineHyperlink extends
@Override
public void onBrowserEvent(final Event event) {
if (DOM.eventGetType(event) == Event.ONCLICK && impl.handleAsClick(event)) {
DOM.eventPreventDefault(event);
event.preventDefault();
go();
} else {
super.onBrowserEvent(event);