opendev/gerrit
Code Issues Proposed changes

ChangeRebuilder: Add dependencies on PatchSetEvent

Browse Source 
This ensures events for patch sets don't get sorted before the
PatchSetEvent that created them. This can happen due to timestamp
skew, or the corner case described in If8ef0726.

Change-Id: I45b16437518fb396e1d42d4aedb21a42258364ac
This commit is contained in:
Dave Borowitz
2016-09-16 13:27:36 -04:00
parent c1e78eda69
commit 96586f59d8
5 changed files with 65 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/server/notedb/ChangeRebuilderIT.java
View File

@@ -715,6 +715,8 @@ public class ChangeRebuilderIT extends AbstractDaemonTest {
rin.message = "comment";
Timestamp ts = new Timestamp(c.getCreatedOn().getTime() + 2000);
assertThat(ts).isGreaterThan(c.getCreatedOn());
assertThat(ts).isLessThan(db.patchSets().get(psId).getCreatedOn());
RevisionResource revRsrc = parseCurrentRevisionResource(r.getChangeId());
postReview.get().apply(revRsrc, rin, ts);