Add project setting for defaulting new changes to WIP
Feature: Issue 8866 Change-Id: I67b144eb3edfb596cfcfb545b273599d82cc04b1
This commit is contained in:
@@ -79,6 +79,8 @@ public interface AdminConstants extends Constants {
|
||||
|
||||
String privateByDefault();
|
||||
|
||||
String workInProgressByDefault();
|
||||
|
||||
String enableReviewerByEmail();
|
||||
|
||||
String matchAuthorToCommitterDate();
|
||||
|
@@ -31,6 +31,7 @@ requireSignedPush = Require signed push
|
||||
requireChangeID = Require <code>Change-Id</code> in commit message
|
||||
rejectImplicitMerges = Reject implicit merges when changes are pushed for review
|
||||
privateByDefault = Set all new changes private by default
|
||||
workInProgressByDefault = Set all new changes work-in-progress by default
|
||||
headingMaxObjectSizeLimit = Maximum Git object size limit
|
||||
headingGroupOptions = Group Options
|
||||
isVisibleToAll = Make group visible to all registered users.
|
||||
|
@@ -87,6 +87,7 @@ public class ProjectInfoScreen extends ProjectScreen {
|
||||
private ListBox requireSignedPush;
|
||||
private ListBox rejectImplicitMerges;
|
||||
private ListBox privateByDefault;
|
||||
private ListBox workInProgressByDefault;
|
||||
private ListBox enableReviewerByEmail;
|
||||
private ListBox matchAuthorToCommitterDate;
|
||||
private NpTextBox maxObjectSizeLimit;
|
||||
@@ -197,6 +198,7 @@ public class ProjectInfoScreen extends ProjectScreen {
|
||||
requireChangeID.setEnabled(isOwner);
|
||||
rejectImplicitMerges.setEnabled(isOwner);
|
||||
privateByDefault.setEnabled(isOwner);
|
||||
workInProgressByDefault.setEnabled(isOwner);
|
||||
maxObjectSizeLimit.setEnabled(isOwner);
|
||||
enableReviewerByEmail.setEnabled(isOwner);
|
||||
matchAuthorToCommitterDate.setEnabled(isOwner);
|
||||
@@ -277,6 +279,10 @@ public class ProjectInfoScreen extends ProjectScreen {
|
||||
saveEnabler.listenTo(privateByDefault);
|
||||
grid.addHtml(AdminConstants.I.privateByDefault(), privateByDefault);
|
||||
|
||||
workInProgressByDefault = newInheritedBooleanBox();
|
||||
saveEnabler.listenTo(workInProgressByDefault);
|
||||
grid.addHtml(AdminConstants.I.workInProgressByDefault(), workInProgressByDefault);
|
||||
|
||||
enableReviewerByEmail = newInheritedBooleanBox();
|
||||
saveEnabler.listenTo(enableReviewerByEmail);
|
||||
grid.addHtml(AdminConstants.I.enableReviewerByEmail(), enableReviewerByEmail);
|
||||
@@ -417,6 +423,7 @@ public class ProjectInfoScreen extends ProjectScreen {
|
||||
}
|
||||
setBool(rejectImplicitMerges, result.rejectImplicitMerges());
|
||||
setBool(privateByDefault, result.privateByDefault());
|
||||
setBool(workInProgressByDefault, result.workInProgressByDefault());
|
||||
setBool(enableReviewerByEmail, result.enableReviewerByEmail());
|
||||
setBool(matchAuthorToCommitterDate, result.matchAuthorToCommitterDate());
|
||||
setSubmitType(result.submitType());
|
||||
@@ -690,6 +697,7 @@ public class ProjectInfoScreen extends ProjectScreen {
|
||||
rsp,
|
||||
getBool(rejectImplicitMerges),
|
||||
getBool(privateByDefault),
|
||||
getBool(workInProgressByDefault),
|
||||
getBool(enableReviewerByEmail),
|
||||
getBool(matchAuthorToCommitterDate),
|
||||
maxObjectSizeLimit.getText().trim(),
|
||||
|
@@ -60,6 +60,9 @@ public class ConfigInfo extends JavaScriptObject {
|
||||
public final native InheritedBooleanInfo privateByDefault()
|
||||
/*-{ return this.private_by_default; }-*/ ;
|
||||
|
||||
public final native InheritedBooleanInfo workInProgressByDefault()
|
||||
/*-{ return this.work_in_progress_by_default; }-*/ ;
|
||||
|
||||
public final native InheritedBooleanInfo enableReviewerByEmail()
|
||||
/*-{ return this.enable_reviewer_by_email; }-*/ ;
|
||||
|
||||
|
@@ -153,6 +153,7 @@ public class ProjectApi {
|
||||
InheritableBoolean requireSignedPush,
|
||||
InheritableBoolean rejectImplicitMerges,
|
||||
InheritableBoolean privateByDefault,
|
||||
InheritableBoolean workInProgressByDefault,
|
||||
InheritableBoolean enableReviewerByEmail,
|
||||
InheritableBoolean matchAuthorToCommitterDate,
|
||||
String maxObjectSizeLimit,
|
||||
@@ -175,6 +176,7 @@ public class ProjectApi {
|
||||
}
|
||||
in.setRejectImplicitMerges(rejectImplicitMerges);
|
||||
in.setPrivateByDefault(privateByDefault);
|
||||
in.setWorkInProgressByDefault(workInProgressByDefault);
|
||||
in.setMaxObjectSizeLimit(maxObjectSizeLimit);
|
||||
in.setSubmitType(submitType);
|
||||
in.setState(state);
|
||||
@@ -311,6 +313,13 @@ public class ProjectApi {
|
||||
|
||||
private native void setPrivateByDefault(String v) /*-{ if(v)this.private_by_default=v; }-*/;
|
||||
|
||||
final void setWorkInProgressByDefault(InheritableBoolean v) {
|
||||
setWorkInProgressByDefault(v.name());
|
||||
}
|
||||
|
||||
private native void setWorkInProgressByDefault(
|
||||
String v) /*-{ if(v)this.work_in_progress_by_default=v; }-*/;
|
||||
|
||||
final void setEnableReviewerByEmail(InheritableBoolean v) {
|
||||
setEnableReviewerByEmailRaw(v.name());
|
||||
}
|
||||
|
Reference in New Issue
Block a user