opendev/gerrit
Code Issues Proposed changes

Merge "Support plugin group reference with inheritance"

Browse Source
This commit is contained in:
Hugo Arès 2017-07-18 11:59:43 +00:00 committed by Gerrit Code Review
commit 9743d7d8b8
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gerrit-server/src/main/java/com/google/gerrit/server/config/PluginConfig.java
View File

@ -57,11 +57,16 @@ public class PluginConfig {
cfg = copyConfig(cfg);
for (String name : parentPluginConfig.cfg.getNames(PLUGIN, pluginName)) {
if (!allNames.contains(name)) {
cfg.setStringList(
PLUGIN,
pluginName,
name,
Arrays.asList(parentPluginConfig.cfg.getStringList(PLUGIN, pluginName, name)));
List<String> values =
Arrays.asList(parentPluginConfig.cfg.getStringList(PLUGIN, pluginName, name));
for (String value : values) {
GroupReference groupRef =
parentPluginConfig.projectConfig.getGroup(GroupReference.extractGroupName(value));
if (groupRef != null) {
projectConfig.resolve(groupRef);
}
}
cfg.setStringList(PLUGIN, pluginName, name, values);
}
}
}