opendev/gerrit
Code Issues Proposed changes

Replace Hashtable with ConcurrentMap

Browse Source 
Hashtable is an ancient class that should never be used in modern Java
code.  ConcurrentMap or a synchronizedMap() are the correct ways to
create a thread-safe Map structure.

Change-Id: Iaa50cde3112c1b9f5063df9fecac646d0eb707da
This commit is contained in:
Shawn Pearce
2013-04-23 17:46:43 -07:00
parent 98c89249c5
commit 9744ba992e
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginLoader.java
View File

@@ -50,7 +50,6 @@ import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collections; import java.util.Collections;
import java.util.Date; import java.util.Date;
import java.util.Hashtable;
import java.util.Iterator; import java.util.Iterator;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
@@ -95,7 +94,7 @@ public class PluginLoader implements LifecycleListener {
disabled = Maps.newConcurrentMap(); disabled = Maps.newConcurrentMap();
broken = Maps.newHashMap(); broken = Maps.newHashMap();
toCleanup = Queues.newArrayDeque(); toCleanup = Queues.newArrayDeque();
cleanupHandles = new Hashtable<Plugin,CleanupHandle>(); cleanupHandles = Maps.newConcurrentMap();
cleaner = pct; cleaner = pct;
long checkFrequency = ConfigUtil.getTimeUnit(cfg, long checkFrequency = ConfigUtil.getTimeUnit(cfg,