opendev/gerrit
Code Issues Proposed changes

Create Review Permission

Browse Source 
This is the first change in a series that intends to getting rid of
refs/for/ from ACLs.

The migration from "push refs/for/*" to "create-review refs/heads/*"
is handled on-the-fly when the configuration is loaded.

Any "push refs/for/*" permission will be  automatially migrated to the
new "Create Review" permission and the old permission will be removed
if possible (e.g. push refs/* will create a new Create Review permission,
but keep the old permission since it will affect refs/{heads,meta}/*).

When the rest of the refs/for/ dependent permissions are migrated, an
offline schema migration should be available to help correct all configs,
though the online auto migration should be available for a few major
versions to help fix ACL-mistakes by users.

Change-Id: Ia112adeb7593a7b4a7a8b5d8b96f72f73c9b70b8
This commit is contained in:
Gustaf Lundh
2017-04-24 14:39:02 +02:00
parent cd0b77954f
commit 97afc05387
13 changed files with 142 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/AdminConstants.properties
View File

@@ -135,6 +135,7 @@ permissionNames = \
abandon, \
addPatchSet, \
create, \
createReview, \
createTag, \
createSignedTag, \
delete, \
@@ -158,6 +159,7 @@ permissionNames = \
abandon = Abandon
addPatchSet = Add Patch Set
create = Create Reference
createReview = Create Review
createTag = Create Annotated Tag
createSignedTag = Create Signed Tag
delete = Delete Reference