opendev/gerrit
Code Issues Proposed changes

workspace-status.sh: quote 'tr' arguments.

Browse Source 
Otherwise, the shell may interpret [a-z], leading to version strings
such as

  STABLE_BUILD_superm[nifest_LABEL 6010213-dirty

Change-Id: I5846efc03419e7361d3171df14646c96f66118ac
This commit is contained in:
Han-Wen Nienhuys
2017-01-12 16:44:03 +01:00
parent 970a4e3db9
commit 97c8fb0f56
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/workspace-status.sh
View File

@@ -17,6 +17,6 @@ function rev() {
echo STABLE_BUILD_GERRIT_LABEL $(rev .) echo STABLE_BUILD_GERRIT_LABEL $(rev .)
for p in plugins/* ; do for p in plugins/* ; do
test -d "$p" || continue test -d "$p" || continue
echo STABLE_BUILD_$(echo $(basename $p)_LABEL|tr [a-z] [A-Z]) $(rev $p) echo STABLE_BUILD_$(echo $(basename $p)_LABEL|tr '[a-z]' '[A-Z]' ) $(rev $p)
done done
echo "STABLE_WORKSPACE_ROOT ${PWD}" echo "STABLE_WORKSPACE_ROOT ${PWD}"