opendev/gerrit
Code Issues Proposed changes

Remove old RPCs to get project details and to update project settings

Browse Source 
These old RPCs are not used anymore. Their functionality is available
over REST.

The visibleProjectDetails RPC was done for the Mylyn Gerrit Connector
to find project details for all projects but permission only projects.

The REST endpoint to list projects does support to filter out
permission only projects so the Gerrit Mylyn Connector can implement
its functionality on REST.

Change-Id: Ie83e9021b564faa401fc0f6405fdd8621d6b7b6f
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-07-17 13:42:45 +02:00
committed by David Pursehouse
parent 7800186ac1
commit 984781e9bb
7 changed files with 1 additions and 411 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectAdminService.java
View File

@@ -27,19 +27,9 @@ import java.util.List;
@RpcImpl(version = Version.V2_0)
public interface ProjectAdminService extends RemoteJsonService {
void visibleProjectDetails(AsyncCallback<List<ProjectDetail>> callback);
void projectDetail(Project.NameKey projectName,
AsyncCallback<ProjectDetail> callback);
void projectAccess(Project.NameKey projectName,
AsyncCallback<ProjectAccess> callback);
@Audit
@SignInRequired
void changeProjectSettings(Project update,
AsyncCallback<ProjectDetail> callback);
@Audit
@SignInRequired
void changeProjectAccess(Project.NameKey projectName, String baseRevision,

84
gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectDetail.java
View File

@@ -1,84 +0,0 @@
// Copyright (C) 2008 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.common.data;
import com.google.gerrit.reviewdb.client.InheritedBoolean;
import com.google.gerrit.reviewdb.client.Project;
public class ProjectDetail {
public Project project;
public boolean canModifyDescription;
public boolean canModifyMergeType;
public boolean canModifyAgreements;
public boolean canModifyAccess;
public boolean canModifyState;
public boolean canModifyMaxObjectSizeLimit;
public boolean isPermissionOnly;
public InheritedBoolean useContributorAgreements;
public InheritedBoolean useSignedOffBy;
public InheritedBoolean useContentMerge;
public InheritedBoolean requireChangeID;
public ProjectDetail() {
}
public void setProject(final Project p) {
project = p;
}
public void setCanModifyDescription(final boolean cmd) {
canModifyDescription = cmd;
}
public void setCanModifyMergeType(final boolean cmmt) {
canModifyMergeType = cmmt;
}
public void setCanModifyState(final boolean cms) {
canModifyState = cms;
}
public void setCanModifyMaxObjectSizeLimit(final boolean cmmosl) {
canModifyMaxObjectSizeLimit = cmmosl;
}
public void setCanModifyAgreements(final boolean cma) {
canModifyAgreements = cma;
}
public void setCanModifyAccess(final boolean cma) {
canModifyAccess = cma;
}
public void setPermissionOnly(final boolean ipo) {
isPermissionOnly = ipo;
}
public void setUseContributorAgreements(final InheritedBoolean uca) {
useContributorAgreements = uca;
}
public void setUseSignedOffBy(final InheritedBoolean usob) {
useSignedOffBy = usob;
}
public void setUseContentMerge(final InheritedBoolean ucm) {
useContentMerge = ucm;
}
public void setRequireChangeID(final InheritedBoolean rcid) {
requireChangeID = rcid;
}
}