Narrow tables that don't have to be 100% width
Especially in the user settings screen, these tables have no need to be 100% of the browser width. Most wind up with too much whitespace that way, making it harder to read. Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
@@ -55,6 +55,7 @@ class AgreementPanel extends Composite {
|
||||
|
||||
private class AgreementTable extends FancyFlexTable<AbstractAgreement> {
|
||||
AgreementTable() {
|
||||
table.setWidth("");
|
||||
table.setText(0, 1, Util.C.agreementStatus());
|
||||
table.setText(0, 2, Util.C.agreementName());
|
||||
table.setText(0, 3, Util.C.agreementDescription());
|
||||
|
||||
@@ -90,6 +90,7 @@ class ExternalIdPanel extends Composite {
|
||||
|
||||
private class IdTable extends FancyFlexTable<AccountExternalId> {
|
||||
IdTable() {
|
||||
table.setWidth("");
|
||||
table.setText(0, 2, Util.C.webIdLastUsed());
|
||||
table.setText(0, 3, Util.C.webIdStatus());
|
||||
table.setText(0, 4, Util.C.webIdEmail());
|
||||
|
||||
@@ -143,6 +143,7 @@ class ProjectWatchPanel extends Composite {
|
||||
|
||||
private class WatchTable extends FancyFlexTable<AccountProjectWatchInfo> {
|
||||
WatchTable() {
|
||||
table.setWidth("");
|
||||
table.insertRow(1);
|
||||
table.setText(0, 2, com.google.gerrit.client.changes.Util.C
|
||||
.changeTableColumnProject());
|
||||
|
||||
@@ -417,6 +417,7 @@ class SshPanel extends Composite {
|
||||
private static final String S_INVALID = "gerrit-SshKeyPanel-Invalid";
|
||||
|
||||
SshKeyTable() {
|
||||
table.setWidth("");
|
||||
table.setText(0, 3, Util.C.sshKeyAlgorithm());
|
||||
table.setText(0, 4, Util.C.sshKeyKey());
|
||||
table.setText(0, 5, Util.C.sshKeyComment());
|
||||
|
||||
@@ -210,6 +210,7 @@ public class ProjectBranchesPanel extends Composite {
|
||||
|
||||
private class BranchesTable extends FancyFlexTable<Branch> {
|
||||
BranchesTable() {
|
||||
table.setWidth("");
|
||||
table.setText(0, 2, Util.C.columnBranchName());
|
||||
table.setHTML(0, 3, " ");
|
||||
|
||||
|
||||
@@ -316,6 +316,7 @@ public class ProjectRightsPanel extends Composite {
|
||||
|
||||
private class RightsTable extends FancyFlexTable<ProjectRight> {
|
||||
RightsTable() {
|
||||
table.setWidth("");
|
||||
table.setText(0, 2, Util.C.columnApprovalCategory());
|
||||
table.setText(0, 3, Util.C.columnGroupName());
|
||||
table.setText(0, 4, Util.C.columnRightRange());
|
||||
|
||||
@@ -45,6 +45,7 @@ public abstract class FancyFlexTable<RowItem> extends Composite {
|
||||
protected FancyFlexTable() {
|
||||
table = createFlexTable();
|
||||
table.addStyleName(MY_STYLE);
|
||||
table.setWidth("100%");
|
||||
initWidget(table);
|
||||
|
||||
table.setText(0, C_ARROW, "");
|
||||
@@ -118,7 +119,7 @@ public abstract class FancyFlexTable<RowItem> extends Composite {
|
||||
|
||||
/**
|
||||
* Get the td element that contains another element.
|
||||
*
|
||||
*
|
||||
* @param target the child element whose parent td is required.
|
||||
* @return the td containing element {@code target}; null if {@code target} is
|
||||
* not a member of this table.
|
||||
|
||||
@@ -244,7 +244,6 @@
|
||||
|
||||
/** ChangeTable **/
|
||||
.gerrit-ChangeTable {
|
||||
width: 100%;
|
||||
border-collapse: separate;
|
||||
border-spacing: 0;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user