opendev/gerrit
Code Issues Proposed changes

Permit restarting a specific plugin

Browse Source 
If a plugin's configuration is modified and the plugin needs to be
reloaded to pick up this new data, permit administrators to tickle the
plugin reload process by supplying the plugin name as an argument for
`gerrit plugin reload`.

Change-Id: If879f5bb8b4913fb6d801a5feae960c25874e4b3
This commit is contained in:
Shawn O. Pearce
2012-05-11 16:19:40 -07:00
parent a252ee599d
commit 98e447b23a
2 changed files with 57 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
gerrit-server/src/main/java/com/google/gerrit/server/plugins/PluginLoader.java
View File

@@ -14,7 +14,9 @@
package com.google.gerrit.server.plugins;
import com.google.common.base.Joiner;
import com.google.common.base.Strings;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import com.google.common.collect.Sets;
import com.google.gerrit.extensions.systemstatus.ServerInformation;
@@ -225,6 +227,40 @@ public class PluginLoader implements LifecycleListener {
}
}
public void reload(List<String> names)
throws InvalidPluginException, PluginInstallException {
synchronized (this) {
List<Plugin> reload = Lists.newArrayListWithCapacity(names.size());
List<String> bad = Lists.newArrayListWithExpectedSize(4);
for (String name : names) {
Plugin active = running.get(name);
if (active != null) {
reload.add(active);
} else {
bad.add(name);
}
}
if (!bad.isEmpty()) {
throw new InvalidPluginException(String.format(
"Plugin(s) \"%s\" not running",
Joiner.on("\", \"").join(bad)));
}
for (Plugin active : reload) {
String name = active.getName();
try {
log.info(String.format("Reloading plugin %s", name));
runPlugin(name, active.getSrcJar(), active);
} catch (PluginInstallException e) {
log.warn(String.format("Cannot reload plugin %s", name), e.getCause());
throw e;
}
}
System.gc();
processPendingCleanups();
}
}
private synchronized boolean rescanImp() {
List<File> jars = scanJarsInPluginsDirectory();
boolean clean = stopRemovedPlugins(jars);