opendev/gerrit
Code Issues Proposed changes

ChangeScreen2: Allow scrolling while reply box is open

Browse Source 
Permit the user to scroll the page to look at the history while typing
a reply.  This can make it easier to reference text written by another.

GWT supports setting the popup non-modal but using glass with an empty
style to get modal like behavior without breaking basic page features
like browser managed scrolling.

Change-Id: I7d29387baa4af88650a9227f61bf549fc223466e
This commit is contained in:
Shawn Pearce
2014-01-17 17:41:25 -08:00
parent 060c0bfc22
commit 99254d34a4
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java
View File

@@ -94,8 +94,10 @@ class ReplyAction {
replyBox.replyTo(msg);
}
final PluginSafePopupPanel p = new PluginSafePopupPanel(true);
final PluginSafePopupPanel p = new PluginSafePopupPanel(true, false);
p.setStyleName(style.replyBox());
p.setGlassEnabled(true);
p.setGlassStyleName("");
p.addAutoHidePartner(replyButton.getElement());
p.addCloseHandler(new CloseHandler<PopupPanel>() {
@Override