opendev/gerrit
Code Issues Proposed changes

Protect the TrackingFooters.extract from null input parameter

Browse Source 
Some code paths could pass null to the TrackingFooters.extract.
An example is [1] which happens when loading of the current patch set
of a change fails.

[1]
at com.google.gerrit.server.config.TrackingFooters.extract(TrackingFooters.java:42)
at com.google.gerrit.server.query.change.OutputStreamQuery.query(OutputStreamQuery.java:247)
...

Change-Id: I27ce4cc0d9606208a8be884646e901004171bd96
This commit is contained in:
Saša Živkov
2016-04-15 13:27:56 +02:00
parent c7cb3dd131
commit 99677f6c5a
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/config/TrackingFooters.java
View File

@@ -39,6 +39,10 @@ public class TrackingFooters {
public Multimap<String, String> extract(List<FooterLine> lines) {
Multimap<String, String> r = ArrayListMultimap.create();
if (lines == null) {
return r;
}
for (FooterLine footer : lines) {
for (TrackingFooter config : trackingFooters) {
if (footer.matches(config.footerKey())) {