opendev/gerrit
Code Issues Proposed changes

Remove modifier check for bracket navigation

Browse Source 
On some keyboards, modifiers are needed for bracket input. This change
removes the check for modifiers to allow for this.

Bug: Issue 5460
Change-Id: Id69a408a927debc94271885bdaf77b4fbe92080b
This commit is contained in:
Kasper Nilsson 2017-02-06 15:31:41 -08:00
parent debaf78b56
commit 997b9a6517
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js
View File

@ -417,16 +417,14 @@
},
_handleLeftBracketKey: function(e) {
if (this.shouldSuppressKeyboardShortcut(e) ||
this.modifierPressed(e)) { return; }
if (this.shouldSuppressKeyboardShortcut(e)) { return; }
e.preventDefault();
this._openSelectedFile(this._files.length - 1);
},
_handleRightBracketKey: function(e) {
if (this.shouldSuppressKeyboardShortcut(e) ||
this.modifierPressed(e)) { return; }
if (this.shouldSuppressKeyboardShortcut(e)) { return; }
e.preventDefault();
this._openSelectedFile(0);