opendev/gerrit
Code Issues Proposed changes

Ensure constants are declared as immutable collections

Browse Source 
This communicates important semantic guarantees to callers, as described
in the ImmutableCollection javadoc. It also makes calls to mutating
methods result in compiler warnings.

PiperOrigin-RevId: 149238269
PiperOrigin-RevId: 148972127
PiperOrigin-RevId: 149233478
PiperOrigin-RevId: 149235768
Change-Id: I6d3de40810c83aaa258c6b93a24a3f9fd18994e8
This commit is contained in:
Dave Borowitz
2017-03-08 10:32:55 -05:00
parent 48e08d7776
commit 99cd8121ea
7 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-server/src/main/java/com/google/gerrit/rules/RulesCache.java
View File

@@ -71,7 +71,8 @@ import org.eclipse.jgit.util.RawParseUtils;
*/
@Singleton
public class RulesCache {
private static final List<String> PACKAGE_LIST = ImmutableList.of(Prolog.BUILTIN, "gerrit");
private static final ImmutableList<String> PACKAGE_LIST =
ImmutableList.of(Prolog.BUILTIN, "gerrit");
private static final class MachineRef extends WeakReference<PrologMachineCopy> {
final ObjectId key;