opendev/gerrit
Code Issues Proposed changes

Move some project classes to extension to expose them in Project API

Browse Source 
Change-Id: I25a8d463b50fd3cd016c7d182790ae54883b7401
This commit is contained in:
David Ostrovsky
2014-02-04 09:20:27 +01:00
committed by David Ostrovsky
parent c72b30cab8
commit 99dea4bfba
55 changed files with 267 additions and 183 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-sshd/BUCK
View File

@@ -46,6 +46,7 @@ java_test(
),
deps = [
':sshd',
'//gerrit-extension-api:api',
'//gerrit-server:server',
'//lib:guava',
'//lib:junit',

9
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateProjectCommand.java
View File

@@ -21,16 +21,17 @@ import com.google.common.collect.Lists;
import com.google.gerrit.common.data.GlobalCapability;
import com.google.gerrit.common.errors.ProjectCreationFailedException;
import com.google.gerrit.extensions.annotations.RequiresCapability;
import com.google.gerrit.extensions.api.projects.ProjectInput;
import com.google.gerrit.extensions.api.projects.ProjectInput.ConfigValue;
import com.google.gerrit.extensions.common.InheritableBoolean;
import com.google.gerrit.extensions.common.SubmitType;
import com.google.gerrit.extensions.restapi.RestApiException;
import com.google.gerrit.extensions.restapi.TopLevelResource;
import com.google.gerrit.reviewdb.client.AccountGroup;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.reviewdb.client.Project.InheritableBoolean;
import com.google.gerrit.reviewdb.client.Project.SubmitType;
import com.google.gerrit.server.project.CreateProject;
import com.google.gerrit.server.project.NoSuchProjectException;
import com.google.gerrit.server.project.ProjectControl;
import com.google.gerrit.server.project.PutConfig.ConfigValue;
import com.google.gerrit.server.project.SuggestParentCandidates;
import com.google.gerrit.sshd.CommandMetaData;
import com.google.gerrit.sshd.SshCommand;
@@ -148,7 +149,7 @@ final class CreateProjectCommand extends SshCommand {
throw new UnloggedFailure(1, "fatal: Project name is required.");
}
CreateProject.Input input = new CreateProject.Input();
ProjectInput input = new ProjectInput();
input.name = projectName;
if (ownerIds != null) {
input.owners = Lists.transform(ownerIds,

8
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/SetProjectCommand.java
View File

@@ -16,10 +16,10 @@ package com.google.gerrit.sshd.commands;
import com.google.gerrit.common.data.GlobalCapability;
import com.google.gerrit.extensions.annotations.RequiresCapability;
import com.google.gerrit.extensions.api.projects.ProjectState;
import com.google.gerrit.extensions.common.InheritableBoolean;
import com.google.gerrit.extensions.common.SubmitType;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.reviewdb.client.Project.InheritableBoolean;
import com.google.gerrit.reviewdb.client.Project.State;
import com.google.gerrit.reviewdb.client.Project.SubmitType;
import com.google.gerrit.server.git.MetaDataUpdate;
import com.google.gerrit.server.git.ProjectConfig;
import com.google.gerrit.server.project.ProjectCache;
@@ -106,7 +106,7 @@ final class SetProjectCommand extends SshCommand {
}
@Option(name = "--project-state", aliases = {"--ps"}, usage = "project's visibility state")
private State state;
private ProjectState state;
@Option(name = "--max-object-size-limit", usage = "max Git object size for this project")
private String maxObjectSizeLimit;

4
gerrit-sshd/src/test/java/com/google/gerrit/sshd/commands/ProjectConfigParamParserTest.java
View File

@@ -14,11 +14,11 @@
package com.google.gerrit.sshd.commands;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertArrayEquals;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNull;
import com.google.gerrit.server.project.PutConfig.ConfigValue;
import com.google.gerrit.extensions.api.projects.ProjectInput.ConfigValue;
import org.junit.Before;
import org.junit.Test;