opendev/gerrit
Code Issues Proposed changes

Add REST endpoint to add members to a group

Browse Source 
With PUT on 'groups/*/members/<NEW-MEMBER>' it is now possible to add a
new member to a group.

In addition with PUT on 'groups/*/members' it is possible to add
multiple new members to a group at once.

The AccountGroupMembersScreen uses the new REST endpoint to add new
members. After a member was added the screen is reloaded. Other changes
should follow to update the displayed member list without reloading the
complete screen.

The Guice bindings needed to be modified to make AccountManager
injectable into PutMember. It was needed to bind an implementation of
SshKeyCache since AccountManager depends on ChangeUserName.Factory
which depends on SshKeyCache.

Change-Id: I8de09da94790a6ad55757a1051f9098f5e937312
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-01-11 17:15:10 +01:00
parent b46c9fb932
commit 9a701696ae
14 changed files with 424 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-sshd/src/main/java/com/google/gerrit/sshd/SshModule.java
View File

@@ -22,8 +22,6 @@ import com.google.gerrit.lifecycle.LifecycleModule;
import com.google.gerrit.server.CmdLineParserModule;
import com.google.gerrit.server.PeerDaemonUser;
import com.google.gerrit.server.RemotePeer;
import com.google.gerrit.server.account.AccountManager;
import com.google.gerrit.server.account.ChangeUserName;
import com.google.gerrit.server.config.FactoryModule;
import com.google.gerrit.server.config.GerritRequestModule;
import com.google.gerrit.server.config.GerritServerConfig;
@@ -44,6 +42,7 @@ import org.apache.sshd.common.KeyPairProvider;
import org.apache.sshd.server.CommandFactory;
import org.apache.sshd.server.PublickeyAuthenticator;
import org.eclipse.jgit.lib.Config;
import java.net.SocketAddress;
import java.util.Map;
@@ -69,7 +68,6 @@ public class SshModule extends FactoryModule {
install(new CmdLineParserModule());
configureAliases();
install(SshKeyCacheImpl.module());
bind(SshLog.class);
bind(SshInfo.class).to(SshDaemon.class).in(SINGLETON);
factory(DispatchCommand.Factory.class);
@@ -83,8 +81,6 @@ public class SshModule extends FactoryModule {
bind(WorkQueue.Executor.class).annotatedWith(StreamCommandExecutor.class)
.toProvider(StreamCommandExecutorProvider.class).in(SINGLETON);
bind(QueueProvider.class).to(CommandExecutorQueueProvider.class).in(SINGLETON);
bind(AccountManager.class);
factory(ChangeUserName.Factory.class);
bind(PublickeyAuthenticator.class).to(DatabasePubKeyAuth.class);
bind(KeyPairProvider.class).toProvider(HostKeyProvider.class).in(SINGLETON);