opendev
/
gerrit
Code Issues Proposed changes

Merge "SideBySide2: Don't open draft on right click in gutter"

This commit is contained in:
Shawn Pearce 2013-12-20 00:51:45 +00:00 committed by Gerrit Code Review
parent 1dd2db24a4 c0aaf8d283
commit 9b28aca43a
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySide2.java
View File

@ -1309,16 +1309,22 @@ public class SideBySide2 extends Screen {
@Override @Override
public void handle(CodeMirror instance, int line, String gutter, public void handle(CodeMirror instance, int line, String gutter,
NativeEvent clickEvent) { NativeEvent clickEvent) {
if (!(cm.hasActiveLine() && if (clickEvent.getButton() == NativeEvent.BUTTON_LEFT
cm.getLineNumber(cm.getActiveLine()) == line)) { && !clickEvent.getMetaKey()
cm.setCursor(LineCharacter.create(line)); && !clickEvent.getAltKey()
} && !clickEvent.getCtrlKey()
Scheduler.get().scheduleDeferred(new ScheduledCommand() { && !clickEvent.getShiftKey()) {
@Override if (!(cm.hasActiveLine() &&
public void execute() { cm.getLineNumber(cm.getActiveLine()) == line)) {
insertNewDraft(cm).run(); cm.setCursor(LineCharacter.create(line));
} }
}); Scheduler.get().scheduleDeferred(new ScheduledCommand() {
@Override
public void execute() {
insertNewDraft(cm).run();
}
});
}
} }
}; };
} }