opendev/gerrit
Code Issues Proposed changes

Merge branch 'stable-3.0' into stable-3.1

Browse Source 
* stable-3.0:
  Bazel: Remove unused polygerrit-ui/app:bower_components rule
  Bazel: Make maven_jar rule forward compatible
  Bazel: Replace deprecated dependency mode LOOSE with PRUNE_LEGACY

Change-Id: I2b81528db04d309418127da41ea70b9ca757fbd2
This commit is contained in:
David Ostrovsky
2019-12-24 21:28:54 +01:00
parent a5e432be78 829f75b3d0
commit 9b871b8f34
4 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
polygerrit-ui/app/BUILD
View File

@@ -45,17 +45,6 @@ filegroup(
),
)
filegroup(
name = "bower_components",
srcs = glob(
[
"bower_components/**/*.html",
"bower_components/**/*.js",
"bower_components/**/*.js.map",
],
),
)
genrule2(
name = "pg_code_zip",
srcs = [":pg_code"],

1
polygerrit-ui/app/rules.bzl
View File

@@ -19,6 +19,7 @@ def polygerrit_bundle(name, srcs, outs, app):
],
language = "ECMASCRIPT_2017",
deps = [name + "_closure_lib"],
dependency_mode = "PRUNE_LEGACY",
)
# TODO(davido): Remove JSC_REFERENCE_BEFORE_DECLARE when this is fixed upstream:

1
tools/bzl/js.bzl
View File

@@ -494,6 +494,7 @@ def polygerrit_plugin(name, app, srcs = [], deps = [], externs = [], assets = No
deps = [
name + "_closure_lib",
],
dependency_mode = "PRUNE_LEGACY",
)
if html_plugin:

1
tools/bzl/maven_jar.bzl
View File

@@ -94,6 +94,7 @@ def _generate_build_files(ctx, binjar, srcjar):
srcjar_attr = 'srcjar = "%s",' % srcjar
contents = """
{header}
load("@rules_java//java:defs.bzl", "java_import")
package(default_visibility = ['//visibility:public'])
java_import(
name = 'jar',