From a41006effa16a3206f84a1f55e4bcd5171258339 Mon Sep 17 00:00:00 2001 From: Edwin Kempin Date: Tue, 10 Sep 2019 11:01:54 +0200 Subject: [PATCH] AddReviewersOp: Remove unneeded variable assignment Signed-off-by: Edwin Kempin Change-Id: Ib14ac46b6aa0dc9ec559d9f131ac17b98c27006e --- java/com/google/gerrit/server/change/AddReviewersOp.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/java/com/google/gerrit/server/change/AddReviewersOp.java b/java/com/google/gerrit/server/change/AddReviewersOp.java index f534feeb8f..15d8c60179 100644 --- a/java/com/google/gerrit/server/change/AddReviewersOp.java +++ b/java/com/google/gerrit/server/change/AddReviewersOp.java @@ -181,12 +181,11 @@ public class AddReviewersOp implements BatchUpdateOp { } } - ImmutableList
addressesToAdd = ImmutableList.of(); ReviewerStateInternal internalState = ReviewerStateInternal.fromReviewerState(state); // TODO(dborowitz): This behavior should live in ApprovalsUtil or something, like addCcs does. ImmutableSet
existing = ctx.getNotes().getReviewersByEmail().byState(internalState); - addressesToAdd = + ImmutableList
addressesToAdd = addresses.stream().filter(a -> !existing.contains(a)).collect(toImmutableList()); if (state == CC) {