remove unused method in ApprovalsUtil

This method is only called from ChangeData, but the second parameter
is never actually used. Migrate that one method to use the other
method (without the allapprovals parameter), and remove method that
is (now) unused.

Change-Id: If1fa7dfa8ee72ebb9d1b03be2fad72b8d235e11d
This commit is contained in:
Gal Paikin
2020-09-30 14:59:11 +03:00
parent 2ce08db469
commit 9c2711f71a
2 changed files with 1 additions and 11 deletions

View File

@@ -116,16 +116,6 @@ public class ApprovalsUtil {
return notes.load().getReviewers();
}
/**
* Get all reviewers and CCed accounts for a change.
*
* @param allApprovals all approvals to consider; must all belong to the same change.
* @return reviewers for the change.
*/
public ReviewerSet getReviewers(ChangeNotes notes, Iterable<PatchSetApproval> allApprovals) {
return notes.load().getReviewers();
}
/**
* Get updates to reviewer set.
*

View File

@@ -682,7 +682,7 @@ public class ChangeData {
// from the index. However, we need these values for permission checks.
throw new IllegalStateException("reviewers not populated");
}
reviewers = approvalsUtil.getReviewers(notes(), approvals().values());
reviewers = approvalsUtil.getReviewers(notes());
}
return reviewers;
}