opendev/gerrit
Code Issues Proposed changes

Use ref equality instead of value equality for revision

Browse Source 
Change-Id: I6690a25e579b3fdb2e256b7472ec8db408222556
This commit is contained in:
Andrew Bonventre
2016-08-05 20:20:31 -04:00
parent 9b0d73966a
commit 9c598701f1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/notedb/ChangeNotesParser.java
View File

@@ -405,7 +405,7 @@ class ChangeNotesParser {
if (ps == null) {
ps = new PatchSet(psId);
patchSets.put(psId, ps);
} else if (ps.getRevision() != PARTIAL_PATCH_SET) {
} else if (!ps.getRevision().equals(PARTIAL_PATCH_SET)) {
if (deletedPatchSets.contains(psId)) {
// Do not update PS details as PS was deleted and this meta data is of
// no relevance
@@ -794,7 +794,7 @@ class ChangeNotesParser {
private void updatePatchSetStates() throws ConfigInvalidException {
for (PatchSet ps : patchSets.values()) {
if (ps.getRevision() == PARTIAL_PATCH_SET) {
if (ps.getRevision().equals(PARTIAL_PATCH_SET)) {
throw parseException("No %s found for patch set %s",
FOOTER_COMMIT, ps.getPatchSetId());
}