opendev/gerrit
Code Issues Proposed changes

Make ListenableAccountDiffPreference final in PatchScriptSettingsPanel

Browse Source 
This field should never be modified after creation as listeners
are wired to it.

Change-Id: Ie80e91a0c1230e68ddd3cb7d001f5268711cd54f
This commit is contained in:
Shawn Pearce
2013-04-26 10:35:20 -07:00
parent 2004180622
commit 9d2c29d7e5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScriptSettingsPanel.java
View File

@@ -50,7 +50,7 @@ public class PatchScriptSettingsPanel extends Composite implements
interface MyUiBinder extends UiBinder<Widget, PatchScriptSettingsPanel> { interface MyUiBinder extends UiBinder<Widget, PatchScriptSettingsPanel> {
} }
private ListenableAccountDiffPreference listenablePrefs; private final ListenableAccountDiffPreference listenablePrefs;
private boolean enableIntralineDifference = true; private boolean enableIntralineDifference = true;
private boolean enableSmallFileFeatures = true; private boolean enableSmallFileFeatures = true;