From 9d3492c0c8b1c3f3bba31c322ebda5bedfef915f Mon Sep 17 00:00:00 2001 From: "alex.ryazantsev" Date: Thu, 14 Nov 2013 02:56:47 +0400 Subject: [PATCH] Remove unnecessary invocation toString() method Change-Id: Ibbf86c9b5a31e65d0f46b869976687727e925624 --- .../main/java/com/google/gerrit/common/data/ReviewerInfo.java | 2 +- .../java/com/google/gerrit/gwtdebug/GerritDebugLauncher.java | 2 +- .../src/main/java/com/google/gerrit/pgm/util/ConsoleUI.java | 2 +- gerrit-sshd/src/main/java/com/google/gerrit/sshd/NoShell.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/ReviewerInfo.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/ReviewerInfo.java index 063f13be4e..28a8340cd8 100644 --- a/gerrit-common/src/main/java/com/google/gerrit/common/data/ReviewerInfo.java +++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/ReviewerInfo.java @@ -51,7 +51,7 @@ public class ReviewerInfo implements Comparable { if (accountInfo.getPreferredEmail() != null) { return accountInfo.getPreferredEmail(); } - return accountInfo.getFullName().toString(); + return accountInfo.getFullName(); } return groupReference.getName(); } diff --git a/gerrit-gwtdebug/src/main/java/com/google/gerrit/gwtdebug/GerritDebugLauncher.java b/gerrit-gwtdebug/src/main/java/com/google/gerrit/gwtdebug/GerritDebugLauncher.java index a2a770ebe6..5770f58904 100644 --- a/gerrit-gwtdebug/src/main/java/com/google/gerrit/gwtdebug/GerritDebugLauncher.java +++ b/gerrit-gwtdebug/src/main/java/com/google/gerrit/gwtdebug/GerritDebugLauncher.java @@ -368,7 +368,7 @@ public class GerritDebugLauncher extends ServletContainerLauncher { AbstractConnector connector = getConnector(); if (bindAddress != null) { - connector.setHost(bindAddress.toString()); + connector.setHost(bindAddress); } connector.setPort(port); diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/ConsoleUI.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/ConsoleUI.java index e8cf0ab212..9af95ab84f 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/ConsoleUI.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/ConsoleUI.java @@ -179,7 +179,7 @@ public abstract class ConsoleUI { } console.printf(" Supported options are:\n"); for (final String v : allowedValues) { - console.printf(" %s\n", v.toString().toLowerCase()); + console.printf(" %s\n", v.toLowerCase()); } } } diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/NoShell.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/NoShell.java index cde7ae88af..78f006b1b6 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/NoShell.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/NoShell.java @@ -106,7 +106,7 @@ class NoShell implements Factory { } finally { sshScope.set(old); } - err.write(Constants.encode(message.toString())); + err.write(Constants.encode(message)); err.flush(); in.close();