From 889d5534bb546ecfdbaf153f21866382c69e0e58 Mon Sep 17 00:00:00 2001 From: Shawn Pearce Date: Fri, 30 Aug 2013 00:10:38 -0700 Subject: [PATCH] ChangeScreen2: Display ellipsis when owner name is long If the owner name is likely to overflow into the change status portion of the header, clip it with an ellipsis. Until the infocard popup is enabled use a browser tooltip on the name element to display the untrimmed name. Bug: issue 2092 Change-Id: I2913c3edf8e749b9a65b6a5111ff4d88683b8696 --- .../java/com/google/gerrit/client/change/ChangeScreen2.java | 6 ++++-- .../com/google/gerrit/client/change/ChangeScreen2.ui.xml | 4 ++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.java index 498b9c244a..3de2269a50 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.java @@ -660,9 +660,11 @@ public class ChangeScreen2 extends Screen { private void renderOwner(ChangeInfo info) { // TODO info card hover - ownerText.setInnerText(info.owner().name() != null + String name = info.owner().name() != null ? info.owner().name() - : Gerrit.getConfig().getAnonymousCowardName()); + : Gerrit.getConfig().getAnonymousCowardName(); + ownerText.setInnerText(name); + ownerText.setTitle(name); } private void renderSubmitType(String action) { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.ui.xml b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.ui.xml index b24b311f9e..6cf7b7b7ef 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.ui.xml +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.ui.xml @@ -61,6 +61,10 @@ limitations under the License. position: absolute; top: 0; left: 29px; + width: 245px; + white-space: nowrap; + overflow: hidden; + text-overflow: ellipsis; } .idStatus { position: absolute;