opendev/gerrit
Code Issues Proposed changes

ApprovalsUtil: Remove declaration of unthrown OrmException

Browse Source 
Change-Id: I85fef25996a9228828495b930c9f366d2f49a014
This commit is contained in:
David Pursehouse
2018-12-20 12:32:45 +09:00
parent 42d8d6eb46
commit 9e28c94f12
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/com/google/gerrit/server/ApprovalsUtil.java
View File

@@ -148,8 +148,7 @@ public class ApprovalsUtil {
PatchSet ps, PatchSet ps,
PatchSetInfo info, PatchSetInfo info,
Iterable<Account.Id> wantReviewers, Iterable<Account.Id> wantReviewers,
Collection<Account.Id> existingReviewers) Collection<Account.Id> existingReviewers) {
throws OrmException {
return addReviewers( return addReviewers(
update, update,
labelTypes, labelTypes,
@@ -191,8 +190,7 @@ public class ApprovalsUtil {
Account.Id authorId, Account.Id authorId,
Account.Id committerId, Account.Id committerId,
Iterable<Account.Id> wantReviewers, Iterable<Account.Id> wantReviewers,
Collection<Account.Id> existingReviewers) Collection<Account.Id> existingReviewers) {
throws OrmException {
List<LabelType> allTypes = labelTypes.getLabelTypes(); List<LabelType> allTypes = labelTypes.getLabelTypes();
if (allTypes.isEmpty()) { if (allTypes.isEmpty()) {
return ImmutableList.of(); return ImmutableList.of();