opendev/gerrit
Code Issues Proposed changes

Iteration by entrySet() instead of keySet()

Browse Source 
Change-Id: I7d4cbe10e42f6200a119c74982b8d000b3948e4f
This commit is contained in:
alex.ryazantsev
2013-11-05 06:01:29 +04:00
parent de1e455385
commit 9e5f632d0a
5 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java
View File

@@ -551,10 +551,10 @@ public class ChangeJson {
Maps.newHashMapWithExpectedSize(labels.size());
if (detailed) {
for (String name : labels.keySet()) {
for (Map.Entry<String, LabelInfo> entry : labels.entrySet()) {
ApprovalInfo ai = approvalInfo(accountId, 0, null);
byLabel.put(name, ai);
labels.get(name).addApproval(ai);
byLabel.put(entry.getKey(), ai);
entry.getValue().addApproval(ai);
}
}
for (PatchSetApproval psa : current.get(accountId)) {